robob/PyTaiko
1
0
Fork 0
mirror of https://github.com/Yonokid/PyTaiko.git synced 2026-02-04 11:40:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(music): Fix the audio volume from music stream not detecting the desired volume

Browse Source 
Apparently, Yonokid used default value for a parameter in
play_music_stream in file `libs/audio.py` and forgot to pass the
supposed argument when using the function.
This commit will completely kill that default value and pass the correct
parameter's value (which is `music`).

Please don't use default parameter anymore, Yono.
This commit is contained in:
QBaraki
2025-10-24 15:12:29 +07:00
parent ed59a64841
commit 52201a39fa
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
libs/audio.py
View File

@@ -327,7 +327,7 @@ class AudioEngine:
print(f"Failed to load music: {file_path}") print(f"Failed to load music: {file_path}")
return "" return ""
def play_music_stream(self, name: str, volume_preset: str = '') -> None: def play_music_stream(self, name: str, volume_preset: str) -> None:
"""Play a music stream""" """Play a music stream"""
if name in self.music_streams: if name in self.music_streams:
music = self.music_streams[name] music = self.music_streams[name]

2
scenes/game.py
View File

@@ -165,7 +165,7 @@ class GameScreen:
def start_song(self, current_time): def start_song(self, current_time):
if (self.current_ms >= self.tja.metadata.offset*1000 + self.start_delay - global_data.config["general"]["judge_offset"]) and not self.song_started: if (self.current_ms >= self.tja.metadata.offset*1000 + self.start_delay - global_data.config["general"]["judge_offset"]) and not self.song_started:
if self.song_music is not None: if self.song_music is not None:
audio.play_music_stream(self.song_music) audio.play_music_stream(self.song_music, 'music')
print(f"Song started at {self.current_ms}") print(f"Song started at {self.current_ms}")
if self.movie is not None: if self.movie is not None:
self.movie.start(current_time) self.movie.start(current_time)

2
scenes/song_select.py
View File

@@ -285,7 +285,7 @@ class SongSelectScreen:
song.box.get_scores() song.box.get_scores()
if song.tja.metadata.wave.exists() and song.tja.metadata.wave.is_file(): if song.tja.metadata.wave.exists() and song.tja.metadata.wave.is_file():
self.demo_song = audio.load_music_stream(song.tja.metadata.wave, 'demo_song') self.demo_song = audio.load_music_stream(song.tja.metadata.wave, 'demo_song')
audio.play_music_stream(self.demo_song) audio.play_music_stream(self.demo_song, 'music')
audio.seek_music_stream(self.demo_song, song.tja.metadata.demostart) audio.seek_music_stream(self.demo_song, song.tja.metadata.demostart)
audio.stop_sound('bgm') audio.stop_sound('bgm')
if song.box.is_open: if song.box.is_open: